GitHub user jkff opened a pull request:
https://github.com/apache/beam/pull/3730
Cleans up PTransform validation across Beam
- Moves validation from validate() to expand() when possible
- Replaces checkNotNull() with checkArgument() when possible
- Shortens overly verbose validation messages in a few IOs
As a piggyback, one of the sites to be cleaned up was AssignWindows which
happened to be unused (it is also unused by Dataflow Worker), so I deleted it.
R: @tgroh
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jkff/incubator-beam validate-cleanup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3730.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3730
----
commit 96196be5800a7028d60af26990d8d3f4f23ad5e4
Author: Eugene Kirpichov <[email protected]>
Date: 2017-08-18T00:48:36Z
Cleans up PTransform validation across Beam
- Moves validation from validate() to expand() when possible
- Replaces checkNotNull() with checkArgument() when possible
- Shortens overly verbose validation messages in a few IOs
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
