[
https://issues.apache.org/jira/browse/BEAM-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16139077#comment-16139077
]
Ben Chambers commented on BEAM-2577:
------------------------------------
I think that PR demonstrates one place we could do this. This bug is to track
the fact that it should be done for every IO that uses Runtime Values, and it
should be done using the runner, etc.
> IO tests should exercise Runtime Values where supported
> -------------------------------------------------------
>
> Key: BEAM-2577
> URL: https://issues.apache.org/jira/browse/BEAM-2577
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-extensions, testing
> Reporter: Ben Chambers
> Assignee: Davor Bonaci
>
> The only tests I have found for `ValueProvider<?>` parameterized methods is
> that they are not evaluated during pipeline construction time. This is
> missing out on several important pieces:
> 1.
> https://stackoverflow.com/questions/44967898/notify-when-textio-is-done-writing-a-file
> seems to be a problem with an AvroIO write using a RuntimeValueProvider
> being non-serializable (current theory is because of an anonymous inner class
> capturing the enclosing AvroIO.Write instance which has non-serializable
> fields).
> 2. Testing that the code paths that actually read the file do so correctly
> when parameterized.
> We should update the developer documentation to describe what the
> requirements are for a parameterized IO and provide guidance on what tests
> are needed and how to write them.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
