[
https://issues.apache.org/jira/browse/BEAM-2798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16140333#comment-16140333
]
ASF GitHub Bot commented on BEAM-2798:
--------------------------------------
Github user asfgit closed the pull request at:
https://github.com/apache/beam/pull/3752
> rename simpleQuery to query and query to queryMulti
> ---------------------------------------------------
>
> Key: BEAM-2798
> URL: https://issues.apache.org/jira/browse/BEAM-2798
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql
> Reporter: Xu Mingmin
> Labels: dsl_sql_merge, dsl_sql_review
>
> One other question from playing around with things more: simpleQuery vs query
> method names. Would it be better if they were named query and queryMulti,
> respectively? Two potential reasons why that might be better: 1) make simple
> things simple, e.g., the single input version should be simpler to express.
> 2) method names typically should be actions/verbs, but simpleQuery makes it
> sound like a noun/object.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
