[
https://issues.apache.org/jira/browse/BEAM-2802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145140#comment-16145140
]
ASF GitHub Bot commented on BEAM-2802:
--------------------------------------
GitHub user echauchot opened a pull request:
https://github.com/apache/beam/pull/3779
[BEAM-2802] Support multi-byte custom separator in TextIO
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the
change (usually before you start working on it). Trivial changes like typos do
not require a JIRA issue. Your pull request should address just this issue,
without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject
line and body.
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/echauchot/beam TextIO-Record-Separator
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3779.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3779
----
commit f3910c2c3d1ebe049d71dafa931bf9f698fab1c1
Author: Etienne Chauchot <[email protected]>
Date: 2017-08-25T15:23:51Z
[BEAM-2802] Support multi-byte custom separator in TextIO
commit 4a8351f05f5109b22199fa032c2ef0db8c106e54
Author: Etienne Chauchot <[email protected]>
Date: 2017-08-29T11:01:44Z
Enhance UTests and add a corner case fix: truncated separator at the end of
a file
commit 974966aaa9bd3e3f3e217d6c3a26a0c35984802f
Author: Etienne Chauchot <[email protected]>
Date: 2017-08-29T11:09:50Z
checkstyle
----
> TextIO should allow specifying a custom delimiter
> -------------------------------------------------
>
> Key: BEAM-2802
> URL: https://issues.apache.org/jira/browse/BEAM-2802
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-extensions
> Reporter: Etienne Chauchot
> Assignee: Etienne Chauchot
> Priority: Minor
>
> Currently TextIO use {{\r}} {{\n}} or {{\r\n}} or a mix of the two to split a
> text file into PCollection elements. It might happen that a record is spread
> across more than one line. In that case we should be able to specify a custom
> record delimiter to be used in place of the default ones.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
