[ 
https://issues.apache.org/jira/browse/BEAM-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16146826#comment-16146826
 ] 

ASF GitHub Bot commented on BEAM-2824:
--------------------------------------

GitHub user peihe opened a pull request:

    https://github.com/apache/beam/pull/3792

    [BEAM-2824]: support PipelineResult.waitUntilFinish() in JStormRunner local 
mode and uses it in TestJStormRunner.

    Follow this checklist to help us incorporate your contribution quickly and 
easily:
    
     - [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the 
change (usually before you start working on it).  Trivial changes like typos do 
not require a JIRA issue.  Your pull request should address just this issue, 
without pulling in other changes.
     - [ ] Each commit in the pull request should have a meaningful subject 
line and body.
     - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA 
issue.
     - [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
     - [ ] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
     - [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/peihe/incubator-beam jstorm-runner-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3792.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3792
    
----
commit 18cfc8ecc06d79d14cc9bcd07414a2471725883d
Author: Pei He <[email protected]>
Date:   2017-08-29T12:10:06Z

    [BEAM-2824]: support PipelineResult.waitUntilFinish() in jstorm local mode.

commit 37bc0bd827ce5612b94d03685cc2ab176c691627
Author: Pei He <[email protected]>
Date:   2017-08-30T06:50:20Z

    [BEAM-2824] Uses PipelineResult in TestJStormRunner.

----


> Support PipelineResult in JStormRunner
> --------------------------------------
>
>                 Key: BEAM-2824
>                 URL: https://issues.apache.org/jira/browse/BEAM-2824
>             Project: Beam
>          Issue Type: New Feature
>          Components: runner-jstorm
>            Reporter: Pei He
>            Assignee: Pei He
>
> Here are the work items:
> 1. supports metrics() in local mode.
> 2. supports waitUntilFinish() in local mode.
> 3. uses PipelineResult in TestJStormRunner.
> 4. supports metrics() in cluster mode.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to