[ 
https://issues.apache.org/jira/browse/BEAM-2804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159226#comment-16159226
 ] 

Kai Jiang commented on BEAM-2804:
---------------------------------

[~mingmxu] I think the scope of this issue should be bigger. 
Not only support timestamp in 
[BeamSortRel|https://github.com/apache/beam/blob/97ad2f8609230861f6804ae2cba6cada42f4c865/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamSortRel.java#L77],
 also we should map 
{code:java}
SQL_TYPE_TO_JAVA_CLASS.put(Types.TIMESTAMP, Timestamp.class);
{code}
 in [BeamRecordType 
|https://github.com/apache/beam/blob/c2acb54f6756786bcfe12e9faf32950fd6260c5e/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/BeamRecordSqlType.java#L71]

Correct me if I am wrong.

> support TIMESTAMP in Sort
> -------------------------
>
>                 Key: BEAM-2804
>                 URL: https://issues.apache.org/jira/browse/BEAM-2804
>             Project: Beam
>          Issue Type: Improvement
>          Components: dsl-sql
>            Reporter: Xu Mingmin
>            Assignee: Shayang Zang
>            Priority: Minor
>              Labels: beginner
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to