[
https://issues.apache.org/jira/browse/BEAM-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163844#comment-16163844
]
ASF GitHub Bot commented on BEAM-2516:
--------------------------------------
GitHub user kennknowles opened a pull request:
https://github.com/apache/beam/pull/3843
[BEAM-2516] Add fast path to ParDoTranslation for known ParDo class
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the
change (usually before you start working on it). Trivial changes like typos do
not require a JIRA issue. Your pull request should address just this issue,
without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject
line and body.
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
These hacked fast paths bring the time back down to the same as before the
portability stuff was put in place. The fast paths will not apply when the
pipeline has gone through a proto round-trip so when I re-enable that
(currently behind experiment flag) I will tackle a cached rehydration (aka
RawParDo) with its own fast path.
R: @tgroh
CC: @iemejia
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/beam ParDoTranslation-shortcut
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3843.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3843
----
commit 9b30bcaa707738da46bd238d3823717e266a8056
Author: Kenneth Knowles <[email protected]>
Date: 2017-09-12T23:22:18Z
Add fast path to ParDoTranslation for known ParDo class
----
> User reports 4 minutes to process 1 million line CSV in DirectRunner
> --------------------------------------------------------------------
>
> Key: BEAM-2516
> URL: https://issues.apache.org/jira/browse/BEAM-2516
> Project: Beam
> Issue Type: Bug
> Components: runner-direct
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Minor
> Fix For: 2.2.0
>
>
> https://stackoverflow.com/questions/44736414/simple-apache-beam-manipulations-work-very-slow
> I don't know what the expectation are here, so I wasn't ready to say this is
> WAI. Low priority since it isn't what the runner is for anyhow, but this
> seems like the scale of data that should be snappy. Worth investigating, or
> maybe you can quickly indicate why it is expected?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
