[ https://issues.apache.org/jira/browse/BEAM-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165344#comment-16165344 ]
ASF GitHub Bot commented on BEAM-2954: -------------------------------------- GitHub user XuMingmin opened a pull request: https://github.com/apache/beam/pull/3848 [BEAM-2954] update shade configurations in extension/sql Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- You can merge this pull request into a Git repository by running: $ git pull https://github.com/XuMingmin/beam BEAM-2954 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/beam/pull/3848.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3848 ---- commit 522e6c188809327f098b84dbd7ee07e1dad4a376 Author: mingmxu <ming...@ebay.com> Date: 2017-09-13T17:31:19Z update shade settings to handle Calcite dependencies ---- > update shade configurations in extension/sql > -------------------------------------------- > > Key: BEAM-2954 > URL: https://issues.apache.org/jira/browse/BEAM-2954 > Project: Beam > Issue Type: Bug > Components: dsl-sql > Reporter: Xu Mingmin > Assignee: Xu Mingmin > Labels: 2.2.0, shade, sql > Fix For: 2.2.0 > > > {{guava}} is shaded by default in beam modules, while {{calcite}}(a > dependency of SQL) includes {{guava}} which is not shaded. Below error is > thrown when calling {{calcite}} methods with guava classed. > {code} > Exception in thread "main" java.lang.NoSuchMethodError: > org.apache.calcite.rel.core.Aggregate.getGroupSets()Lorg/apache/beam/sdks/java/extensions/sql/repackaged/com/google/common/collect/ImmutableList; > at > org.apache.beam.sdk.extensions.sql.impl.rule.BeamAggregationRule.updateWindowTrigger(BeamAggregationRule.java:139) > at > org.apache.beam.sdk.extensions.sql.impl.rule.BeamAggregationRule.onMatch(BeamAggregationRule.java:73) > at > org.apache.calcite.plan.volcano.VolcanoRuleCall.onMatch(VolcanoRuleCall.java:212) > at > org.apache.calcite.plan.volcano.VolcanoPlanner.findBestExp(VolcanoPlanner.java:650) > at > org.apache.calcite.tools.Programs$RuleSetProgram.run(Programs.java:368) > at > org.apache.calcite.prepare.PlannerImpl.transform(PlannerImpl.java:313) > at > org.apache.beam.sdk.extensions.sql.impl.planner.BeamQueryPlanner.convertToBeamRel(BeamQueryPlanner.java:149) > at > org.apache.beam.sdk.extensions.sql.impl.planner.BeamQueryPlanner.validateAndConvert(BeamQueryPlanner.java:140) > at > org.apache.beam.sdk.extensions.sql.impl.planner.BeamQueryPlanner.convertToBeamRel(BeamQueryPlanner.java:128) > at > org.apache.beam.sdk.extensions.sql.impl.planner.BeamQueryPlanner.compileBeamPipeline(BeamQueryPlanner.java:113) > at > org.apache.beam.sdk.extensions.sql.impl.BeamSqlCli.compilePipeline(BeamSqlCli.java:62) > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)