[
https://issues.apache.org/jira/browse/BEAM-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165502#comment-16165502
]
ASF GitHub Bot commented on BEAM-2956:
--------------------------------------
GitHub user lukecwik opened a pull request:
https://github.com/apache/beam/pull/3849
[BEAM-2956] Attempt to correctly report the Dataflow distribution in GCP
related modules.
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the
change (usually before you start working on it). Trivial changes like typos do
not require a JIRA issue. Your pull request should address just this issue,
without pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject
line and body.
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lukecwik/incubator-beam master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3849.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3849
----
commit e9176e9939f0dd61789718203cca95ed760e0954
Author: Luke Cwik <[email protected]>
Date: 2017-09-14T00:00:04Z
[BEAM-2956] Attempt to correctly report the Dataflow distribution in GCP
related modules.
----
> DataflowRunner incorrectly reports the user agent for the Dataflow
> distribution
> -------------------------------------------------------------------------------
>
> Key: BEAM-2956
> URL: https://issues.apache.org/jira/browse/BEAM-2956
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Affects Versions: 2.0.0, 2.1.0
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Fix For: 2.2.0
>
>
> The DataflowRunner when distributed with the Dataflow SDK distribution may
> incorrectly submit a user agent and properties from the Apache Beam
> distribution.
> This occurs when the Apache Beam jars appear on the classpath before the
> Dataflow SDK distribution. The fix is to not have two files at the same path
> but to use two different paths, where the lack of the second path means that
> we are using the Apache Beam distribution and its existence implies we are
> using the Dataflow distribution.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
