[
https://issues.apache.org/jira/browse/BEAM-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169446#comment-16169446
]
ASF GitHub Bot commented on BEAM-2884:
--------------------------------------
GitHub user kennknowles opened a pull request:
https://github.com/apache/beam/pull/3858
[BEAM-2884] Move DoFnInfo to SDK util
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the
change (usually before you start working on it). Trivial changes like typos do
not require a JIRA issue. Your pull request should address just this issue,
without pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject
line and body.
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
- [x] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
Previously, the DoFnInfo wrapped things just enough for Dataflow to execute
a DoFn without much context. The Java SDK harness has the same need, and relies
on DoFnInfo. Effectively, DoFnInfo is the UDF that the Java SDK harness
understands.
This also helps to break the dependency between the Java SDK harness and
the Dataflow runner codebase, by just moving it to be an allowed dependency.
This will require a new worker image.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/beam DoFnInfo
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3858.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3858
----
commit d8f03d7a3d749dcd279b35377e25dc8884dc5a64
Author: Kenneth Knowles <k...@google.com>
Date: 2017-09-16T22:16:56Z
Move DoFnInfo to SDK util
Previously, the DoFnInfo wrapped things just enough for Dataflow to execute
a
DoFn without much context. The Java SDK harness has the same need, and
relies
on DoFnInfo. Effectively, DoFnInfo is the UDF that the Java SDK harness
understands.
----
> Dataflow runs portable pipelines
> --------------------------------
>
> Key: BEAM-2884
> URL: https://issues.apache.org/jira/browse/BEAM-2884
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Reporter: Henning Rohde
> Assignee: Thomas Groh
> Labels: portability
>
> Dataflow should run pipelines using the full portability API as currently
> defined:
> https://s.apache.org/beam-fn-api
> https://s.apache.org/beam-runner-api
> https://s.apache.org/beam-job-api
> https://s.apache.org/beam-fn-api-container-contract
> This issue tracks its adoption of the portability framework. New Fn API and
> other features will be tracked separately.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
