This is an automated email from the ASF dual-hosted git repository. mergebot-role pushed a commit to branch mergebot in repository https://gitbox.apache.org/repos/asf/beam-site.git
commit a7eba5237c118b61e0fb1a052112848eb977de0e Author: melissa <[email protected]> AuthorDate: Thu Sep 14 15:49:11 2017 -0700 Update with review feedback --- src/documentation/programming-guide.md | 2 +- src/get-started/mobile-gaming-example.md | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/documentation/programming-guide.md b/src/documentation/programming-guide.md index 061a36a..bcd7218 100644 --- a/src/documentation/programming-guide.md +++ b/src/documentation/programming-guide.md @@ -1684,7 +1684,7 @@ You set the trigger(s) for a `PCollection` by invoking the method `.triggering() This code sample sets a time-based trigger for a `PCollection`, which emits results one minute after the first element in that window has been processed. The last line in the code sample, `.discardingFiredPanes()`, is the window's **accumulation mode**. -#### Window Accumulation Modes +#### <a name="window-accumulation-modes"></a>Window Accumulation Modes When you specify a trigger, you must also set the the window's **accumulation mode**. When a trigger fires, it emits the current contents of the window as a pane. Since a trigger can fire multiple times, the accumulation mode determines whether the system *accumulates* the window panes as the trigger fires, or *discards* them. diff --git a/src/get-started/mobile-gaming-example.md b/src/get-started/mobile-gaming-example.md index c8d7606..35c9dc0 100644 --- a/src/get-started/mobile-gaming-example.md +++ b/src/get-started/mobile-gaming-example.md @@ -42,7 +42,7 @@ The following diagram shows the ideal situation (events are processed as they oc width="264" height="260" alt="Score data for three users."> </figure> -**Figure 1:** The X-axis represents event time: the actual time a game event occurred. The Y-axis represents processing time: the time at which a game event was processed. Ideally, events should be processed as they occur, depicted by the dotted line in the diagram. However, in reality that is not the case and reality looks more like what is depicted by the red squiggly line. +**Figure 1:** The X-axis represents event time: the actual time a game event occurred. The Y-axis represents processing time: the time at which a game event was processed. Ideally, events should be processed as they occur, depicted by the dotted line in the diagram. However, in reality that is not the case and it looks more like what is depicted by the red squiggly line. The data events might be received by the game server significantly later than users generate them. This time difference (called **skew**) can have processing implications for pipelines that make calculations that consider when each score was generated. Such pipelines might track scores generated during each hour of a day, for example, or they calculate the length of time that users are continuously playing the game—both of which depend on each data record's event time. @@ -267,7 +267,7 @@ The following code example shows how `LeaderBoard` sets the processing time trig {% github_sample /apache/beam/blob/master/sdks/python/apache_beam/examples/complete/game/leader_board.py tag:processing_time_trigger %}``` -Note that `LeaderBoard` uses an accumulating trigger for the user score calculation (by <span class="language-java">invoking `.accumulatingFiredPanes`</span> <span class="language-py">using `accumulation_mode=trigger.AccumulationMode.ACCUMULATING`</span> when setting the trigger). Using an accumulating trigger causes the pipeline to accumulate the previously emitted data together with any new data that's arrived since the last trigger fire. This ensures that `LeaderBoard` is a running su [...] +`LeaderBoard` sets the [window accumulation mode]({{ site.baseurl }}/documentation/programming-guide/#window-accumulation-modes) to accumulate window panes as the trigger fires. This accumulation mode is set by <span class="language-java">invoking `.accumulatingFiredPanes`</span> <span class="language-py">using `accumulation_mode=trigger.AccumulationMode.ACCUMULATING`</span> when setting the trigger, and causes the pipeline to accumulate the previously emitted data together with any new [...] #### Calculating Team Score based on Event Time -- To stop receiving notification emails like this one, please contact "[email protected]" <[email protected]>.
