[
https://issues.apache.org/jira/browse/BEAM-3016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16194785#comment-16194785
]
ASF GitHub Bot commented on BEAM-3016:
--------------------------------------
GitHub user lukecwik reopened a pull request:
https://github.com/apache/beam/pull/3944
[BEAM-3016] Fix blocking issue within run() when channel terminates while
blocking within DirectStreamObserver.
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the
change (usually before you start working on it). Trivial changes like typos do
not require a JIRA issue. Your pull request should address just this issue,
without pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject
line and body.
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
- [x] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lukecwik/incubator-beam fn_api
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3944.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3944
----
commit 43964a933ae2d3ce72b7658dce885fde1c8e9865
Author: Luke Cwik <[email protected]>
Date: 2017-10-06T16:09:17Z
[BEAM-3016] Fix blocking issue within run() when channel terminates while
blocking within DirectStreamObserver.
----
> BeamFnLoggingClient shutdown stability
> --------------------------------------
>
> Key: BEAM-3016
> URL: https://issues.apache.org/jira/browse/BEAM-3016
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-harness
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: Minor
>
> The BeamFnLoggingClient has a race condition where it may not shutdown
> appropriately if the channel has an error.
> This occurs because the stream observer created by the StreamObserverFactory
> may block indefinitely if the DirectStreamObserver is used.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
