[
https://issues.apache.org/jira/browse/BEAM-2682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16206642#comment-16206642
]
ASF GitHub Bot commented on BEAM-2682:
--------------------------------------
GitHub user jkff opened a pull request:
https://github.com/apache/beam/pull/3999
[BEAM-2682] Deletes AvroIOTransformTest
Instead, merges the little test coverage it provided into AvroIOTest.
This supersedes https://github.com/apache/beam/pull/3948 - merging these
two test classes is long overdue and AvroIOTransformTest was quite bad code:
* the parameterized tests in AvroIOTransformTest were considerably more
verbose and less readable than doing the same thing without parameterization
* it provided little additional coverage over AvroIOTest
* it didn't use the "write pipeline, then read pipeline" recommended
approach
R: @echauchot
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jkff/incubator-beam rm-avroio-transform
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3999.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3999
----
commit b59a7423fbdad9dd104a0c3161378ff343cf4401
Author: Eugene Kirpichov <[email protected]>
Date: 2017-10-16T21:48:17Z
[BEAM-2682] Deletes AvroIOTransformTest
Instead, merges the little test coverage it provided into AvroIOTest.
----
> Merge AvroIOTest and AvroIOTransformTest
> ----------------------------------------
>
> Key: BEAM-2682
> URL: https://issues.apache.org/jira/browse/BEAM-2682
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Eugene Kirpichov
> Assignee: Eugene Kirpichov
>
> These two tests seem to have exactly the same purpose. They should be merged
> into AvroIOTest.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
