[
https://issues.apache.org/jira/browse/BEAM-3114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16222851#comment-16222851
]
ASF GitHub Bot commented on BEAM-3114:
--------------------------------------
GitHub user herohde opened a pull request:
https://github.com/apache/beam/pull/4053
[BEAM-3114] Generate text proto config properly in container boot code
Also disable stack trace optimization in java container.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/herohde/beam containers
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/4053.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4053
----
commit 9aa77ebaa638e4d1582aabff6ddc00da9c7bbfde
Author: Henning Rohde <[email protected]>
Date: 2017-10-27T18:30:57Z
Add all portability protos to Go
commit 3a2c64f0cfe533cb093561de98e78aace74b2231
Author: Henning Rohde <[email protected]>
Date: 2017-10-27T18:31:33Z
Fix Go package comment for syscallx
commit 9384fd6be4bdfe994d5013b980c280879aa8dc3f
Author: Henning Rohde <[email protected]>
Date: 2017-10-27T20:38:26Z
[BEAM-3113] Disable stack trace optimization in java container
commit c3dbb4c0b79939e9a4f6c42db9e3a65b2509aba1
Author: Henning Rohde <[email protected]>
Date: 2017-10-27T21:20:10Z
[BEAM-3114] Generate text proto config properly in container boot code
----
> Do not generate ApiService text proto string manually in containers
> -------------------------------------------------------------------
>
> Key: BEAM-3114
> URL: https://issues.apache.org/jira/browse/BEAM-3114
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-harness
> Reporter: Henning Rohde
> Assignee: Henning Rohde
> Priority: Minor
> Labels: portability
>
> We should generate that string using the proto library instead of printf. It
> broke us when the ID was removed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
