[
https://issues.apache.org/jira/browse/BEAM-3054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226109#comment-16226109
]
ASF GitHub Bot commented on BEAM-3054:
--------------------------------------
GitHub user jkff opened a pull request:
https://github.com/apache/beam/pull/4060
[BEAM-3054] Uses locale-insensitive number formatting in ESIO and tests
The ESIO5 test framework will randomly switch the locale of the current
test, and hence it discovered this bug: this is an actual bug.
This commit switches %d to %s where appropriate, i.e. where a
machine-readable decimal number in US locale is required.
R: @echauchot
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jkff/incubator-beam esio-locale
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/4060.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4060
----
commit e647a961669c0afca3ece4194f99d8d1ea5fd52d
Author: Eugene Kirpichov <[email protected]>
Date: 2017-10-31T01:48:48Z
[BEAM-3054] Uses locale-insensitive number formatting in ESIO and tests
The ESIO5 test framework will randomly switch the locale of the current
test, and hence it discovered this bug: this is an actual bug.
This commit switches %d to %s where appropriate, i.e. where a
machine-readable decimal number in US locale is required.
----
> org.apache.beam.sdk.io.elasticsearch.ElasticsearchIOTest is flaky
> -----------------------------------------------------------------
>
> Key: BEAM-3054
> URL: https://issues.apache.org/jira/browse/BEAM-3054
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-extensions
> Reporter: Valentyn Tymofieiev
> Assignee: Etienne Chauchot
>
> From a precommit test:
> https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/15049/consoleFull
> 2017-10-13T00:49:17.586 [ERROR]
> testRead(org.apache.beam.sdk.io.elasticsearch.ElasticsearchIOTest) Time
> elapsed: 12.054 s <<< ERROR!
> java.io.IOException: Failed to insert test documents in index beam
> at
> __randomizedtesting.SeedInfo.seed([4A7FFDE90B849587:80A19E9BC55DC1A2]:0)
> at
> org.apache.beam.sdk.io.elasticsearch.ElasticSearchIOTestUtils.insertTestDocuments(ElasticSearchIOTestUtils.java:79)
> at
> org.apache.beam.sdk.io.elasticsearch.ElasticsearchIOTestCommon.testRead(ElasticsearchIOTestCommon.java:113)
> at
> org.apache.beam.sdk.io.elasticsearch.ElasticsearchIOTest.testRead(ElasticsearchIOTest.java:119)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1713)
> at
> com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:907)
> at
> com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:943)
> at
> com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:957)
> at
> org.apache.beam.sdk.testing.TestPipeline$1.evaluate(TestPipeline.java:327)
> at
> org.junit.rules.ExpectedException$ExpectedExceptionStatement.evaluate(ExpectedException.java:239)
> at
> com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
> at
> org.apache.lucene.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:49)
> at
> org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:45)
> at
> org.apache.lucene.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:48)
> at
> org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:64)
> at
> org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:47)
> at
> com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
> at
> com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:368)
> at
> com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:817)
> at
> com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:468)
> at
> com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:916)
> at
> com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:802)
> at
> com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:852)
> at
> com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:863)
> at
> org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:45)
> at
> com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
> at
> org.apache.lucene.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:41)
> at
> com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
> at
> com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
> at
> com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
> at
> com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
> at
> com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
> at
> org.apache.lucene.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
> at
> org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:47)
> at
> org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:64)
> at
> org.apache.lucene.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:54)
> at
> com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
> at
> com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:368)
> at java.lang.Thread.run(Thread.java:748)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
