[
https://issues.apache.org/jira/browse/BEAM-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242998#comment-16242998
]
ASF GitHub Bot commented on BEAM-3150:
--------------------------------------
GitHub user angoenka opened a pull request:
https://github.com/apache/beam/pull/4094
[BEAM-3150] Fix threading for progress reporting in SDKHarness
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the
change (usually before you start working on it). Trivial changes like typos do
not require a JIRA issue. Your pull request should address just this issue,
without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject
line and body.
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
Progress reporting should happen on a separate thread than worker thread to
avoid delay in reporting progress.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/angoenka/beam progress_report_thread_bug_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/4094.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4094
----
commit b25e5f362bb5ebe17dfd48bcbd11c2ae6c932245
Author: Ankur Goenka <[email protected]>
Date: 2017-11-07T22:02:29Z
[BEAM-3150] Fix threading for progress reporting in SDKHarness
----
> SpannerWriteIT broken by syntax error
> -------------------------------------
>
> Key: BEAM-3150
> URL: https://issues.apache.org/jira/browse/BEAM-3150
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-gcp
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Blocker
>
> Looks like a typo
> {code}
> (c00399bfb3ee161c): com.google.cloud.spanner.SpannerException:
> INVALID_ARGUMENT: Syntax error: Unexpected keyword WHERE [at 1:95]
> ...FROM information_schema.columns as c WHERE where c.table_catalog = '' AND
> ...
> ^
> {code}
> https://builds.apache.org/job/beam_PostCommit_Java_MavenInstall/5182/org.apache.beam$beam-runners-google-cloud-dataflow-java/testReport/org.apache.beam.sdk.io.gcp.spanner/SpannerWriteIT/testWrite/
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)