[
https://issues.apache.org/jira/browse/BEAM-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243048#comment-16243048
]
ASF GitHub Bot commented on BEAM-3156:
--------------------------------------
GitHub user rniemo-g opened a pull request:
https://github.com/apache/beam/pull/4095
[BEAM-3156] Fix BigTableIO to use non-deprecated Futures.addCallback
function
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [ x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the
change (usually before you start working on it). Trivial changes like typos do
not require a JIRA issue. Your pull request should address just this issue,
without pulling in other changes.
- [ x] Each commit in the pull request should have a meaningful subject
line and body.
- [ x] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue.
- [x ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
- [x ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
Jira issue: https://issues.apache.org/jira/browse/BEAM-3156
This PR changes which Futures.addCallback() overload we call. This is
because the overload we're using is being deprecated.
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rniemo-g/beam master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/4095.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4095
----
commit 961bd22d1ae4f7a9b4dc87e7b3c30a26ce1878cd
Author: Ryan Niemocienski <[email protected]>
Date: 2017-10-31T20:56:15Z
Fix BigTableIO to use non-deprecated Futures.addCallback function
----
> Use non-deprecated Futures.addCallback function.
> ------------------------------------------------
>
> Key: BEAM-3156
> URL: https://issues.apache.org/jira/browse/BEAM-3156
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-gcp
> Reporter: Ryan Niemocienski
> Assignee: Chamikara Jayalath
> Priority: Minor
>
> addCallback(ListenableFuture, FutureCallback) is in the process of being
> deprecated in favor of addCallback(ListenableFuture, FutureCallback,
> Executor). Currently BigtableIO uses the former function call; switch it to
> the second one.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
