[
https://issues.apache.org/jira/browse/BEAM-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251741#comment-16251741
]
ASF GitHub Bot commented on BEAM-3187:
--------------------------------------
GitHub user iemejia opened a pull request:
https://github.com/apache/beam/pull/4130
[BEAM-3187] Ensure that teardown is called in case of Exception (DON'T
MERGE)
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the
change (usually before you start working on it). Trivial changes like typos do
not require a JIRA issue. Your pull request should address just this issue,
without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject
line and body.
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/iemejia/beam BEAM-3187-dofn-spark
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/4130.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4130
----
commit 42f06d23bf79fef338628de70f4ff58605666931
Author: Ismaël Mejía <[email protected]>
Date: 2017-11-14T17:03:58Z
[BEAM-3187] Ensure that teardown is called in case of Exception on
start/finish
----
> Spark runner does not call the teardown function if DoFn throws Exception on
> finishBundle
> -----------------------------------------------------------------------------------------
>
> Key: BEAM-3187
> URL: https://issues.apache.org/jira/browse/BEAM-3187
> Project: Beam
> Issue Type: Bug
> Components: runner-spark
> Affects Versions: 2.1.0
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
>
> The lifecycle of the DoFn is not respected in the case of an Exception on the
> finishBundle method. The Spark runner does not call the teardown function of
> the DoFn as it should since this should be dual with the setup.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
