[ https://issues.apache.org/jira/browse/BEAM-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16263006#comment-16263006 ]
ASF GitHub Bot commented on BEAM-3180: -------------------------------------- GitHub user akedin opened a pull request: https://github.com/apache/beam/pull/4165 [BEAM-3180][NexmarkLauncher] Extract EventSources Extracting event sources out from NexmarkLauncher. Refactoring to make the launcher smaller. This is the first commit, trying to split [the previous large PR](https://github.com/apache/beam/pull/4110) into smaller chunks. Plus this is rebased on top of master. Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- You can merge this pull request into a Git repository by running: $ git pull https://github.com/akedin/beam nexmark-generator-refactor-rebase Alternatively you can review and apply these changes as the patch at: https://github.com/apache/beam/pull/4165.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4165 ---- commit 5cc1ca934cc672b3d5e97ee405ab586e08b32c93 Author: Anton Kedin <ke...@google.com> Date: 2017-11-07T21:44:58Z [BEAM-3147][NexmarkLauncher] Extract EventSourceFactory and Event sources out from NexmarkLauncher Refactoring to make the launcher smaller. ---- > [Nexmark][SQL] Refactor NexmarkLauncher > --------------------------------------- > > Key: BEAM-3180 > URL: https://issues.apache.org/jira/browse/BEAM-3180 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql > Reporter: Anton Kedin > Assignee: Anton Kedin > > NexmarkLauncher is a huge class which handles everything about running the > queries, from generation of entities, managing sources and sinks, to > monitoring the perf. And it has zero coverage. > It needs to be split into few components, at least need to move event > generation, sources and sinks creation, and monitoring into their own > components. -- This message was sent by Atlassian JIRA (v6.4.14#64029)