[
https://issues.apache.org/jira/browse/BEAM-2524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16269818#comment-16269818
]
ASF GitHub Bot commented on BEAM-2524:
--------------------------------------
tgroh commented on a change in pull request #4144: [BEAM-2524] Update the
gcloud cancel command to include the --region flag.
URL: https://github.com/apache/beam/pull/4144#discussion_r153664913
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/util/MonitoringUtil.java
##########
@@ -214,8 +214,8 @@ public static String
getGcloudCancelCommand(DataflowPipelineOptions options, Str
}
// Assemble cancel command from optional prefix and project/job parameters.
- return String.format("%s%s jobs --project=%s cancel %s",
- dataflowApiOverridePrefix, GCLOUD_DATAFLOW_PREFIX,
options.getProject(), jobId);
+ return String.format("%s%s jobs --project=%s cancel %s --region=%s",
Review comment:
I'm generically confused about this ordering; is the region part of the
cancel command, or can it be in the same location as the `project` flag (which
is preferable to me)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Update Google Cloud Console URL returned by DataflowRunner to support regions.
> ------------------------------------------------------------------------------
>
> Key: BEAM-2524
> URL: https://issues.apache.org/jira/browse/BEAM-2524
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Reporter: Robert Burke
> Assignee: Robert Burke
> Fix For: 2.2.0
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Both the Java and Python Dataflow Runners need to be updated with a
> regionalized form of the Google Cloud Console URL to support multiple
> Dataflow Regions.
> The new URL format will be:
> https://console.cloud.corp.google.com/dataflow/jobsDetail/locations/<regionId>/jobs/<jobId>?project=<projectId>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
