[ 
https://issues.apache.org/jira/browse/BEAM-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16270891#comment-16270891
 ] 

ASF GitHub Bot commented on BEAM-3244:
--------------------------------------

aljoscha commented on a change in pull request #4174: [BEAM-3244] Ensure 
execution of teardown method on Flink's DoFnOperator
URL: https://github.com/apache/beam/pull/4174#discussion_r153809786
 
 

 ##########
 File path: 
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
 ##########
 @@ -380,7 +386,6 @@ public void close() throws Exception {
       }
     }
     checkFinishBundleTimer.cancel(true);
 
 Review comment:
   yes, you're right. This can also be moved to `dispose()`. 👍 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Flink runner does not respect ParDo's lifecycle on case of exceptions
> ---------------------------------------------------------------------
>
>                 Key: BEAM-3244
>                 URL: https://issues.apache.org/jira/browse/BEAM-3244
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-flink
>    Affects Versions: 2.2.0
>            Reporter: Ismaël Mejía
>            Assignee: Ismaël Mejía
>
> The lifecycle of the DoFn is not respected in case of exception in any of the 
> lifecycle methods after setup.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to