[
https://issues.apache.org/jira/browse/BEAM-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271787#comment-16271787
]
ASF GitHub Bot commented on BEAM-1872:
--------------------------------------
robertwb commented on a change in pull request #4040: [BEAM-1872] Add
IdentityWindowFn for use in Reshuffle
URL: https://github.com/apache/beam/pull/4040#discussion_r153939801
##########
File path: sdks/python/apache_beam/testing/util_test.py
##########
@@ -32,18 +37,56 @@ def test_assert_that_passes(self):
with TestPipeline() as p:
assert_that(p | Create([1, 2, 3]), equal_to([1, 2, 3]))
+ def test_assert_that_passes_empty_equal_to(self):
+ with TestPipeline() as p:
+ assert_that(p | Create([]), equal_to([]))
+
+ def test_assert_that_passes_empty_is_empty(self):
+ with TestPipeline() as p:
+ assert_that(p | Create([]), is_empty())
+
+ def test_windowed_value_passes(self):
+ expected = [TestWindowedValue(v, MIN_TIMESTAMP, [GlobalWindow()])
+ for v in [1, 2, 3]]
+ with TestPipeline() as p:
+ assert_that(p | Create([2, 3, 1]), equal_to(expected),
reify_windows=True)
+
def test_assert_that_fails(self):
- with self.assertRaises(Exception):
+ with self.assertRaises(BeamAssertException):
Review comment:
Not all runners preserve exceptions from remote workers. Please change back.
(Same elsewhere.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> implement Reshuffle transform in python, make it experimental in Java
> ---------------------------------------------------------------------
>
> Key: BEAM-1872
> URL: https://issues.apache.org/jira/browse/BEAM-1872
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core, sdk-py-core
> Reporter: Ahmet Altay
> Assignee: Udi Meiri
> Labels: sdk-consistency
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
