[
https://issues.apache.org/jira/browse/BEAM-3164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271803#comment-16271803
]
ASF GitHub Bot commented on BEAM-3164:
--------------------------------------
robertwb closed pull request #4126: [BEAM-3164] Flush stderr on failures
URL: https://github.com/apache/beam/pull/4126
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/sdks/python/gen_protos.py b/sdks/python/gen_protos.py
index c7bf55f3893..2f0ffbadfd7 100644
--- a/sdks/python/gen_protos.py
+++ b/sdks/python/gen_protos.py
@@ -132,9 +132,13 @@ def _install_grpcio_tools_and_generate_proto_files():
logging.warning(
'Installing grpcio-tools took %0.2f seconds.' % (time.time() - start))
finally:
+ sys.stderr.flush()
shutil.rmtree(build_path)
sys.path.append(install_path)
- generate_proto_files()
+ try:
+ generate_proto_files()
+ finally:
+ sys.stderr.flush()
if __name__ == '__main__':
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Capture stderr logs during gen proto
> ------------------------------------
>
> Key: BEAM-3164
> URL: https://issues.apache.org/jira/browse/BEAM-3164
> Project: Beam
> Issue Type: Bug
> Components: build-system, sdk-py-core
> Reporter: holdenk
> Assignee: Holden Karau
>
> Currently python PRs are failing with gen-proto failures, but these are
> difficult to debug because we don't capture the information (see
> https://builds.apache.org/job/beam_PreCommit_Python_MavenInstall/727/console
> ).
> cc [~altay] [~robertwb]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
