[
https://issues.apache.org/jira/browse/BEAM-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16273713#comment-16273713
]
ASF GitHub Bot commented on BEAM-3143:
--------------------------------------
holdenk commented on a change in pull request #4183: [BEAM-3143] Type Inference
Python 3 Compatibility
URL: https://github.com/apache/beam/pull/4183#discussion_r154239638
##########
File path: sdks/python/apache_beam/typehints/opcodes.py
##########
@@ -261,13 +264,22 @@ def build_list(state, arg):
def load_attr(state, arg):
+ """Replaces the top of the stack, TOS, with with
+ getattr(TOS, co_names[arg])
+ """
o = state.stack.pop()
name = state.get_name(arg)
if isinstance(o, Const) and hasattr(o.value, name):
state.stack.append(Const(getattr(o.value, name)))
elif (isinstance(o, type)
Review comment:
So I have a small improvement here that's in
39b21bfa22bf8fbf5107bdff354252be3ca75cd2 if you want to include it (but
optional)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix type inference in Python 3 for generators
> ---------------------------------------------
>
> Key: BEAM-3143
> URL: https://issues.apache.org/jira/browse/BEAM-3143
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: holdenk
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
