[
https://issues.apache.org/jira/browse/BEAM-413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279330#comment-16279330
]
ASF GitHub Bot commented on BEAM-413:
-------------------------------------
huygaa11 opened a new pull request #4219: [BEAM-413] Created local annotation
for floating point equality warning.
URL: https://github.com/apache/beam/pull/4219
Equals method for the CountSum is used in a test that makes sure encoding
and decoding CountSum object results in an equal object. Since
coderDecodeEncodeEqual method below takes an object and does the equality check
automatically, it is easier to keep the equals() function with annotation than
removing it and writing custom method instead of coderDecodeEncodeEqual.
CoderProperties.coderDecodeEncodeEqual(coder, countSumObject);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Mean$CountSum tests for floating point equality
> -----------------------------------------------
>
> Key: BEAM-413
> URL: https://issues.apache.org/jira/browse/BEAM-413
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Scott Wegner
> Assignee: Batkhuyag Batsaikhan
> Priority: Minor
> Labels: findbugs, newbie, starter
>
> [FindBugs
> FE_FLOATING_POINT_EQUALITY|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L298]:
> Test for floating point equality
> Applies to:
> [Mean$CountSum.equals|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Mean.java#L165].
> This is a good starter bug. When fixing, please remove the corresponding
> entries from
> [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml]
> and verify the build passes.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
