[ 
https://issues.apache.org/jira/browse/BEAM-3324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292937#comment-16292937
 ] 

ASF GitHub Bot commented on BEAM-3324:
--------------------------------------

wcn3 opened a new pull request #4269: BEAM-3324 improve symtab memory usage
URL: https://github.com/apache/beam/pull/4269
 
 
   Change the symbol table lookup to read from a file rather than
   loading the file into memory. This is a space/time tradeoff, but
   lookups can be cached so we can get good speed with a much lower
   memory footprint.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> symtab.go shouldn't read entire file into memory
> ------------------------------------------------
>
>                 Key: BEAM-3324
>                 URL: https://issues.apache.org/jira/browse/BEAM-3324
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-go
>            Reporter: Bill Neubauer
>            Assignee: Bill Neubauer
>            Priority: Minor
>
> The implementation of symtab.go reads the entire binary into memory. This is 
> wasteful of memory, and it should just use os.File as the backing reader. If 
> performance becomes an issue, we can use a modest amount of memory to cache 
> lookups and avoid filesystem reads.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to