[
https://issues.apache.org/jira/browse/BEAM-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299235#comment-16299235
]
ASF GitHub Bot commented on BEAM-3357:
--------------------------------------
aaltay closed pull request #4287: [BEAM-3357] Add generated pb2 files to mvn
clean.
URL: https://github.com/apache/beam/pull/4287
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/pom.xml b/pom.xml
index 8abd9159458..987a995fd71 100644
--- a/pom.xml
+++ b/pom.xml
@@ -2010,6 +2010,10 @@
<include>**/sdks/python/LICENSE</include>
<include>**/sdks/python/NOTICE</include>
<include>**/sdks/python/README.md</include>
+
<include>**/sdks/python/apache_beam/portability/api/*pb2*.*</include>
+ <include>**/sdks/python/**/*.c</include>
+ <include>**/sdks/python/**/*.so</include>
+ <include>**/sdks/python/**/*.egg</include>
</includes>
<followSymlinks>false</followSymlinks>
</fileset>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Python SDK head fails to run tests due to
> Requirement.parse('protobuf<=3.4.0,>=3.2.0')
> --------------------------------------------------------------------------------------
>
> Key: BEAM-3357
> URL: https://issues.apache.org/jira/browse/BEAM-3357
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Chamikara Jayalath
> Priority: Critical
>
> Error is:
> running build_ext
> Traceback (most recent call last):
> File "setup.py", line 202, in <module>
> 'test': generate_protos_first(test),
> File
> "/Users/chamikara/testing/test_py_12_14_2017_2/env_proto_3.4/lib/python2.7/site-packages/setuptools/__init__.py",
> line 129, in setup
> return distutils.core.setup(**attrs)
> File
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/core.py",
> line 151, in setup
> dist.run_commands()
> File
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/dist.py",
> line 953, in run_commands
> self.run_command(cmd)
> File
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/dist.py",
> line 972, in run_command
> cmd_obj.run()
> File "setup.py", line 142, in run
> super(cmd, self).run()
> File
> "/Users/chamikara/testing/test_py_12_14_2017_2/env_proto_3.4/lib/python2.7/site-packages/setuptools/command/test.py",
> line 225, in run
> with self.project_on_sys_path():
> File
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/contextlib.py",
> line 17, in __enter__
> return self.gen.next()
> File
> "/Users/chamikara/testing/test_py_12_14_2017_2/env_proto_3.4/lib/python2.7/site-packages/setuptools/command/test.py",
> line 164, in project_on_sys_path
> require('%s==%s' % (ei_cmd.egg_name, ei_cmd.egg_version))
> File
> "/Users/chamikara/testing/test_py_12_14_2017_2/env_proto_3.4/lib/python2.7/site-packages/pkg_resources/__init__.py",
> line 984, in require
> needed = self.resolve(parse_requirements(requirements))
> File
> "/Users/chamikara/testing/test_py_12_14_2017_2/env_proto_3.4/lib/python2.7/site-packages/pkg_resources/__init__.py",
> line 875, in resolve
> raise VersionConflict(dist, req).with_context(dependent_req)
> pkg_resources.ContextualVersionConflict: (protobuf 3.5.0.post1
> (/Users/chamikara/testing/test_py_12_14_2017_2/beam/sdks/python/.eggs/protobuf-3.5.0.post1-py2.7.egg),
> Requirement.parse('protobuf<=3.4.0,>=3.2.0'), set(['apache-beam']))
> Seems like grpcio did a release today which is breaking us:
> https://pypi.python.org/pypi/grpcio/1.8.1
> We have to either bump our protobuf dependency or reduce the upper bound of
> grpcio dependency to previous release (1.7.3).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
