[ 
https://issues.apache.org/jira/browse/BEAM-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16306393#comment-16306393
 ] 

ASF GitHub Bot commented on BEAM-3217:
--------------------------------------

lgajowy opened a new pull request #4332: [BEAM-3217] add HadoopInputFormatIO 
integration test using DBInputFormat
URL: https://github.com/apache/beam/pull/4332
 
 
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
    - [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the 
change (usually before you start working on it).  Trivial changes like typos do 
not require a JIRA issue.  Your pull request should address just this issue, 
without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line 
and body.
    - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA 
issue.
    - [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
    - [ ] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   
   @chamikaramj could you take a look whether this PR is going to a good 
direction? What do you think about the idea of using JdbcIO to write the data 
(there is no write in HadoopInputFormatIO)? 
   
   Currently the test is working only for small datasets (100 000 rows, which 
is about 3,43 MB). For 1 000 000 (and above) rows the test is flaky (different 
hashes get generated). I'm investigating the cause right now.
   
   For a large scale scenario: will 100 000 000 (3,4 GB) rows of data be 
enough, or should we generate even larger dataset? 
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Add a performance test for HadoopInputFormatIO
> ----------------------------------------------
>
>                 Key: BEAM-3217
>                 URL: https://issues.apache.org/jira/browse/BEAM-3217
>             Project: Beam
>          Issue Type: Test
>          Components: sdk-java-extensions
>            Reporter: Chamikara Jayalath
>            Assignee: Ɓukasz Gajowy
>
> We should add a large scale performance test for HadoopInputFormatIO. We 
> should use PerfKitBenchmarker based performance testing framework [1] to 
> manage Kubernetes based muti-node data store and to publish benchmark results.
> Example input format implementation to use: DBInputFormat to connect to a 
> Postgres instance.
> https://github.com/hanborq/hadoop/blob/master/src/mapred/org/apache/hadoop/mapreduce/lib/db/DBInputFormat.java
>  
> Example docker image to use: https://hub.docker.com/_/postgres/
> [1] https://beam.apache.org/documentation/io/testing/



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to