[
https://issues.apache.org/jira/browse/BEAM-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16309771#comment-16309771
]
ASF GitHub Bot commented on BEAM-3405:
--------------------------------------
iemejia opened a new pull request #4339: [BEAM-3405] Make maxNumRecords a long
instead of an int for KinesisIO
URL: https://github.com/apache/beam/pull/4339
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the
change (usually before you start working on it). Trivial changes like typos do
not require a JIRA issue. Your pull request should address just this issue,
without pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Make maxNumRecords a long for KinesisIO
> ---------------------------------------
>
> Key: BEAM-3405
> URL: https://issues.apache.org/jira/browse/BEAM-3405
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-extensions
> Affects Versions: 2.3.0
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: Minor
>
> KinesisIO as other unbounded sources has a method for bounded reads that sets
> a maximum number of records to be read, this PR makes this parameter a long
> as it is the case with other IOs. It also simplifies the logic for the
> bounded read.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
