[
https://issues.apache.org/jira/browse/BEAM-3354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16310464#comment-16310464
]
ASF GitHub Bot commented on BEAM-3354:
--------------------------------------
huygaa11 opened a new pull request #4341: [BEAM-3354] Fixed a bug that
prevented processing time timers to be reset
URL: https://github.com/apache/beam/pull/4341
Timers should be resetting its timestamp when called consequently.
Currently, this is the case for the event time timers due to
https://github.com/apache/beam/commit/7f14c463acd2ae5b86ac81a9528ac4aa7dff765f.
However, it was not implemented for the processing time timers. As a result,
processing time timers are setting new timers instead of resetting. This PR
completes the implementation.
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the
change (usually before you start working on it). Trivial changes like typos do
not require a JIRA issue. Your pull request should address just this issue,
without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Timer setRelative() does not reset previously set timer.
> --------------------------------------------------------
>
> Key: BEAM-3354
> URL: https://issues.apache.org/jira/browse/BEAM-3354
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Batkhuyag Batsaikhan
> Assignee: Batkhuyag Batsaikhan
>
> When running a pipeline with Timer on direct runner as mentioned in
> https://beam.apache.org/blog/2017/08/28/timely-processing.html, multiple
> calls to setRelative() is starting new timers rather than resetting. (set()
> method is resetting the timer correctly)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
