[
https://issues.apache.org/jira/browse/BEAM-3456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322473#comment-16322473
]
ASF GitHub Bot commented on BEAM-3456:
--------------------------------------
lgajowy opened a new pull request #4392: [BEAM-3456] Enable jenkins and large
scale scenario in JDBC
URL: https://github.com/apache/beam/pull/4392
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the
change (usually before you start working on it). Trivial changes like typos do
not require a JIRA issue. Your pull request should address just this issue,
without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
This one allows JDBC to utilize the numberOfRecords pipeline option too, so
that tests of different scale are possible.
Note that:
- I changed numberOfRecord's type from Long to Integer because to reach
even tens of GBs we are fine with it and we do not need to do unnecessary long
-> int conversions.
- I double-checked it now and it seems that JdbcIO is fine with large
amounts of data. 5 000 000 db rows test works well.
@iemejia @chamikaramj could you take a look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Enable large scale JdbcIOIT Performance Test
> --------------------------------------------
>
> Key: BEAM-3456
> URL: https://issues.apache.org/jira/browse/BEAM-3456
> Project: Beam
> Issue Type: Bug
> Components: testing
> Reporter: Łukasz Gajowy
> Assignee: Łukasz Gajowy
>
> We should use numberOfRecords pipelineOption in Jdbc performance test and
> enable jenkins for it.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
