[
https://issues.apache.org/jira/browse/BEAM-3160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329756#comment-16329756
]
ASF GitHub Bot commented on BEAM-3160:
--------------------------------------
lukecwik opened a new pull request #4433: [BEAM-3160] Prevent issue where we
would choose which coder to use arbitrarily when it is over specified with
multiple coders.
URL: https://github.com/apache/beam/pull/4433
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the
change (usually before you start working on it). Trivial changes like typos do
not require a JIRA issue. Your pull request should address just this issue,
without pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Type based coder inference incorrectly assumes that a coder for one type is
> equivalent to every other coder for that type.
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: BEAM-3160
> URL: https://issues.apache.org/jira/browse/BEAM-3160
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Luke Cwik
> Priority: Major
> Fix For: 2.3.0
>
>
> We should prevent coder inference from assuming that two coders for the same
> type are interchangeable.
> Two Avro GenericRecord coders with different schemas are considered identical
> and an arbitrary one is returned by the Coder/Type inference system if the
> GenericRecord type appears multiple times.
> e.g.
> *KvCoder.of(IterableCoder.of(AvroCoder.of(SchemaA)),
> IterableCoder.of(AvroCoder.of(SchemaB)))* after coder inference for the type
> *KV<Iterable<GenericRecord>, Iterable<GenericRecord>>* will return
> *KvCoder.of(IterableCoder.of(AvroCoder.of(SchemaX)),
> IterableCoder.of(AvroCoder.of(SchemaX)))* where SchemaX is either SchemaA or
> SchemaB.
> Code:
> https://github.com/apache/beam/blob/v2.1.1/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/CoderRegistry.java#L420
> and other Type -> Coder maps in the same file should prevent insertion if
> the type already exists and the coders aren't equal.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
