This is an automated email from the ASF dual-hosted git repository. lcwik pushed a commit to branch go-sdk in repository https://gitbox.apache.org/repos/asf/beam.git
commit 8a9d916be7b9945e9b7576dbf52f0a80b3249cbd Author: Henning Rohde <[email protected]> AuthorDate: Thu Jan 18 19:04:21 2018 -0800 CR: fix DynFn comments --- sdks/go/pkg/beam/core/graph/fn.go | 4 +++- sdks/go/pkg/beam/core/runtime/exec/fn.go | 4 ---- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/sdks/go/pkg/beam/core/graph/fn.go b/sdks/go/pkg/beam/core/graph/fn.go index 032227f..6ed05a1 100644 --- a/sdks/go/pkg/beam/core/graph/fn.go +++ b/sdks/go/pkg/beam/core/graph/fn.go @@ -61,7 +61,9 @@ type DynFn struct { Name string // T is the type of the generated function T reflect.Type - // Data holds the data for the generator. This data is trivially serializable. + // Data holds the data, if any, for the generator. Each function + // generator typically needs some configuration data, which is + // required by the DynFn to be encoded. Data []byte // Gen is the function generator. The function generator itself must be a // function with a unique symbol. diff --git a/sdks/go/pkg/beam/core/runtime/exec/fn.go b/sdks/go/pkg/beam/core/runtime/exec/fn.go index 49a9bac..9ad422f 100644 --- a/sdks/go/pkg/beam/core/runtime/exec/fn.go +++ b/sdks/go/pkg/beam/core/runtime/exec/fn.go @@ -26,10 +26,6 @@ import ( "github.com/apache/beam/sdks/go/pkg/beam/core/util/reflectx" ) -// NOTE(herohde) 12/11/2017: the below helpers are ripe for type-specialization, -// if the reflection overhead here turns out to be significant. It would -// be nice to be able to quantify any potential improvements first, however. - // MainInput is the main input and is unfolded in the invocation, if present. type MainInput struct { Key FullValue -- To stop receiving notification emails like this one, please contact "[email protected]" <[email protected]>.
