[
https://issues.apache.org/jira/browse/BEAM-3412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337601#comment-16337601
]
ASF GitHub Bot commented on BEAM-3412:
--------------------------------------
sduskis opened a new pull request #4462: [BEAM-3412] Upgrade Cloud Bigtable to
1.0.0
URL: https://github.com/apache/beam/pull/4462
The 1.0.0 Cloud Bigtable client upgrade included a non-backwards compatible
change in protobuf generation. Specifically, addAllXXXX() methods no longer
work correctly. `BigtableServiceImpl` used `addAllMutations()`, which caused
run-time breakages. To get around that, add each Mutation independently to the
protobuf object.
This PR also adds unit tests for BigtableServiceImpl so that read/write
interactions do not cause runtime problems.
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the
change (usually before you start working on it). Trivial changes like typos do
not require a JIRA issue. Your pull request should address just this issue,
without pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
- [x] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Update BigTable client version to 1.0
> -------------------------------------
>
> Key: BEAM-3412
> URL: https://issues.apache.org/jira/browse/BEAM-3412
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-gcp
> Reporter: Chamikara Jayalath
> Assignee: Solomon Duskis
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
