[ 
https://issues.apache.org/jira/browse/BEAM-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16338284#comment-16338284
 ] 

ASF GitHub Bot commented on BEAM-1589:
--------------------------------------

huygaa11 opened a new pull request #4482: [BEAM-1589]  Added 
@onWindowExpiration annotation.
URL: https://github.com/apache/beam/pull/4482
 
 
   Added @onWindowExpiration annotation for annotating a user defined method 
(similar to a method annotated with @onTimer), which allows user to do some 
work before garbage collection. For example, users can use this annotation to 
write a method that extracts a value saved in a state before garbage collection.
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
    - [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the 
change (usually before you start working on it).  Trivial changes like typos do 
not require a JIRA issue.  Your pull request should address just this issue, 
without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line 
and body.
    - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA 
issue.
    - [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
    - [ ] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Add OnWindowExpiration method to Stateful DoFn
> ----------------------------------------------
>
>                 Key: BEAM-1589
>                 URL: https://issues.apache.org/jira/browse/BEAM-1589
>             Project: Beam
>          Issue Type: New Feature
>          Components: runner-core, sdk-java-core
>            Reporter: Jingsong Lee
>            Assignee: Batkhuyag Batsaikhan
>            Priority: Major
>
> See BEAM-1517
> This allows the user to do some work before the state's garbage collection.
> It seems kind of annoying, but on the other hand forgetting to set a final 
> timer to flush state is probably data loss most of the time.
> FlinkRunner does this work very simply, but other runners, such as 
> DirectRunner, need to traverse all the states to do this, and maybe it's a 
> little hard.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to