[
https://issues.apache.org/jira/browse/BEAM-3527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16338696#comment-16338696
]
ASF GitHub Bot commented on BEAM-3527:
--------------------------------------
ClaireMcGinty opened a new pull request #4484: [BEAM-3527] Fix construction
order of DistributionResult.ZERO
URL: https://github.com/apache/beam/pull/4484
`Long.MIN_VALUE` and `Long.MAX_VALUE` are provided in the wrong order to the
DistributionResult constructor, causing confusion in our default metrics
reporting.
---
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the
change (usually before you start working on it). Trivial changes like typos do
not require a JIRA issue. Your pull request should address just this issue,
without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> org.apache.beam.sdk.metrics.DistributionResult mixes up min and max
> constructor args
> -------------------------------------------------------------------------------------
>
> Key: BEAM-3527
> URL: https://issues.apache.org/jira/browse/BEAM-3527
> Project: Beam
> Issue Type: Bug
> Components: runner-core
> Reporter: Claire McGinty
> Assignee: Kenneth Knowles
> Priority: Minor
>
> [GitHub link to
> class|https://github.com/apache/beam/blob/a39960b131674e6c1d120a971b91b37226c88414/sdks/java/core/src/main/java/org/apache/beam/sdk/metrics/DistributionResult.java]
> given the constructor:
>
> {code:java}
> public static DistributionResult create(long sum, long count, long min, long
> max){code}
>
> the ZERO value
>
> {code:java}
> public static final DistributionResult ZERO = create(0, 0, Long.MAX_VALUE,
> Long.MIN_VALUE){code}
>
> should be:
>
> {code:java}
> public static final DistributionResult ZERO = create(0, 0, Long.MIN_VALUE,
> Long.MAX_VALUE);{code}
>
> unless this is intentional...?
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
