[
https://issues.apache.org/jira/browse/BEAM-3194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kenneth Knowles updated BEAM-3194:
----------------------------------
Comment: was deleted
(was: bjchambers commented on a change in pull request #4135: [BEAM-3194] Add
@RequiresStableInput annotation
URL: https://github.com/apache/beam/pull/4135#discussion_r153564337
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/DoFn.java
##########
@@ -567,6 +567,29 @@ public Duration getAllowedTimestampSkew() {
@Target(ElementType.METHOD)
public @interface ProcessElement {}
+ /**
+ * <b><i>Experimental - no backwards compatibility guarantees. The exact
name or usage of this
+ * feature may change.</i></b>
+ *
+ * <p>Annotation that may be added to a {@link ProcessElement} or {@link
OnTimer} method to
Review comment:
Can you elaborate on what this means for a timer? At first glance, it seems
like a timer is just "this timer you set fired", so it should never be
unstable. Possible thoughts:
- Are the values of side-inputs observed in a stable way? If not, that
should be clearly documented (maybe even enforced -- any DoFn that requires
stable input should not be allowed to have side inputs).
- Are the set of elements that may have been observed (and thus put into
state) stable?
- Something else I may be missing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
)
> Support annotating that a DoFn requires stable / deterministic input for
> replay/retry
> -------------------------------------------------------------------------------------
>
> Key: BEAM-3194
> URL: https://issues.apache.org/jira/browse/BEAM-3194
> Project: Beam
> Issue Type: New Feature
> Components: beam-model
> Reporter: Kenneth Knowles
> Assignee: Eugene Kirpichov
> Priority: Major
>
> See the thread:
> https://lists.apache.org/thread.html/5fd81ce371aeaf642665348f8e6940e308e04275dd7072f380f9f945@%3Cdev.beam.apache.org%3E
> We need this in order to have truly cross-runner end-to-end exactly once via
> replay + idempotence.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
