[ 
https://issues.apache.org/jira/browse/BEAM-3610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350784#comment-16350784
 ] 

Anton Kedin edited comment on BEAM-3610 at 2/2/18 7:11 PM:
-----------------------------------------------------------

[This PR|https://github.com/apache/beam/pull/4546] fixes this:
 - [Old 
implementation|https://github.com/apache/beam/commit/ecd89b856ffd85baa769ecbe27615ffaf79f2195#diff-b0b2c6af2f694e5f6d9a1c64cbc482a1L105];
 - [New 
Implementation|https://github.com/apache/beam/commit/ecd89b856ffd85baa769ecbe27615ffaf79f2195#diff-7cc1c86643991914521ada54ecf53ceeR104];
 - 
[Tests|https://github.com/apache/beam/commit/ecd89b856ffd85baa769ecbe27615ffaf79f2195#diff-4f4ffa265fe666e99c37c346d50da67dR320];


was (Author: kedin):
[This PR|https://github.com/apache/beam/pull/4546] fixes this:
 - [Old 
implementation|https://github.com/apache/beam/commit/ecd89b856ffd85baa769ecbe27615ffaf79f2195#diff-b0b2c6af2f694e5f6d9a1c64cbc482a1L105];
 - 
[Implementation|https://github.com/apache/beam/commit/ecd89b856ffd85baa769ecbe27615ffaf79f2195#diff-7cc1c86643991914521ada54ecf53ceeR104];
 - 
[Tests|https://github.com/apache/beam/commit/ecd89b856ffd85baa769ecbe27615ffaf79f2195#diff-4f4ffa265fe666e99c37c346d50da67dR320];

> [SQL] Fix HOP definition
> ------------------------
>
>                 Key: BEAM-3610
>                 URL: https://issues.apache.org/jira/browse/BEAM-3610
>             Project: Beam
>          Issue Type: Bug
>          Components: dsl-sql
>            Reporter: Anton Kedin
>            Priority: Major
>
> Current HOP implementation has parameters in wrong order, according to 
> Calcite doc. Sliding window size and frequency are swapped
>  
> According to [Calcite 
> docs|https://calcite.apache.org/docs/reference.html#grouped-window-functions] 
> the syntax is:
> {code:SQL}
> HOP(timestamp_field, frequency_interval, window_size)
> {code}
> We have 
> {code:SQL}
> HOP(timestamp_field, window_size, frequency_interval)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to