[ https://issues.apache.org/jira/browse/BEAM-3664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372869#comment-16372869 ]
Kenneth Knowles commented on BEAM-3664: --------------------------------------- [~wslulciuc] I just read through the test. We have a few tests like this. I think they are a bit overspecified. I would suggest: 1. Eliminate the for loop and just pass the input docs to {{TestStream.addElements}}. 2. Verify that the output is as expected. 3. Determine a way to track insert requests to Solr. Could be via a fake {{solrClient}} (probably best) or by tweaking the data you insert with request ids. 4. Verify that no request exceeded the max size. > Port SolrIOTest off DoFnTester > ------------------------------ > > Key: BEAM-3664 > URL: https://issues.apache.org/jira/browse/BEAM-3664 > Project: Beam > Issue Type: Sub-task > Components: io-java-solr > Reporter: Kenneth Knowles > Priority: Major > Labels: beginner, newbie, starter > -- This message was sent by Atlassian JIRA (v7.6.3#76005)