[
https://issues.apache.org/jira/browse/BEAM-3699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xu Mingmin closed BEAM-3699.
----------------------------
Resolution: Duplicate
Fix Version/s: (was: 2.4.0)
Not applicable
> RecordTimestamp should be the default Watermark in KafkaIO
> ----------------------------------------------------------
>
> Key: BEAM-3699
> URL: https://issues.apache.org/jira/browse/BEAM-3699
> Project: Beam
> Issue Type: Bug
> Components: io-java-kafka
> Reporter: Xu Mingmin
> Assignee: Xu Mingmin
> Priority: Major
> Fix For: Not applicable
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Currently, the priority to get Watermark Instance in KafkaIO is:
> {code}
> getWatermarkFn().apply(curRecord)
> getTimestampFn().apply(record)
> Instant.now()
> {code}
> I would propose to change it as below to leverage {{KafkaRecord.timestamp}}
> if no {{WatermarkFn()}} or {{TimestampFn()}} is available:
> {code}
> getWatermarkFn().apply(curRecord)
> getTimestampFn().apply(record)
> KafkaRecord(Beam.KafkaIO).timestamp
> {code}
> It equals to
> {code}
> getWatermarkFn().apply(curRecord)
> getTimestampFn().apply(record)
> KafkaRawRecord(Kafka_client).timestamp
> Instant.now()
> {code}
> [~rangadi] any comments?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
