Ben Sidhom created BEAM-3793: -------------------------------- Summary: SDK harness should log bad gRPC responses Key: BEAM-3793 URL: https://issues.apache.org/jira/browse/BEAM-3793 Project: Beam Issue Type: Bug Components: sdk-go Reporter: Ben Sidhom Assignee: Henning Rohde
As of now, if a null ProvisionInfo is passed to the boot code, it panics when trying to convert to JSON. It should at the very least log a useful error message if a bad ProvisionInfo is received. Sample stack trace: panic: reflect: call of reflect.Value.Field on zero Value goroutine 1 [running]: reflect.Value.Field(0x0, 0x0, 0x0, 0x0, 0x0, 0x1, 0x81f2e0) /Users/sidhom/.gradle/go/binary/1.9/go/src/reflect/value.go:759 +0x12e github.com/apache/beam/sdks/java/boot/vendor/github.com/golang/protobuf/jsonpb.(*Marshaler).marshalObject(0xc42015cb10, 0xc4201bbbb0, 0xb7a7e0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xc4201bbbd0, 0x410e58) /Users/sidhom/Downloads/git/beam/sdks/java/container/.gogradle/project_gopath/src/github.com/apache/beam/sdks/java/boot/vendor/github.com/golang/protobuf/jsonpb/jsonpb.go:207 +0x1040 github.com/apache/beam/sdks/java/boot/vendor/github.com/golang/protobuf/jsonpb.(*Marshaler).Marshal(0xc42015cb10, 0xb70ae0, 0xc4201ac770, 0xb7a7e0, 0x0, 0x8a53e0, 0x4c3601) /Users/sidhom/Downloads/git/beam/sdks/java/container/.gogradle/project_gopath/src/github.com/apache/beam/sdks/java/boot/vendor/github.com/golang/protobuf/jsonpb/jsonpb.go:122 +0xc1 github.com/apache/beam/sdks/java/boot/vendor/github.com/golang/protobuf/jsonpb.(*Marshaler).MarshalToString(0xc42015cb10, 0xb7a7e0, 0x0, 0x1, 0x15, 0x0, 0x0) /Users/sidhom/Downloads/git/beam/sdks/java/container/.gogradle/project_gopath/src/github.com/apache/beam/sdks/java/boot/vendor/github.com/golang/protobuf/jsonpb/jsonpb.go:128 +0x6e github.com/apache/beam/sdks/java/boot/vendor/github.com/apache/beam/sdks/go/pkg/beam/provision.ProtoToJSON(0x0, 0x12, 0xc4201bbdc0, 0x1, 0x1) /Users/sidhom/Downloads/git/beam/sdks/java/container/.gogradle/project_gopath/src/github.com/apache/beam/sdks/java/boot/vendor/github.com/apache/beam/sdks/go/pkg/beam/provision/provison.go:79 +0x51 main.main() /Users/sidhom/Downloads/git/beam/sdks/java/container/.gogradle/project_gopath/src/github.com/apache/beam/sdks/java/boot/boot.go:80 +0x309 -- This message was sent by Atlassian JIRA (v7.6.3#76005)