[ 
https://issues.apache.org/jira/browse/BEAM-3749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390271#comment-16390271
 ] 

Xu Mingmin commented on BEAM-3749:
----------------------------------

I get your point, below code doesn't use the trigger set in 
{{Window.<Row>configure().triggering}}, it use a {{DefaultTrigger}}:
{code}
input.apply(Window.<Row>configure().triggering( ... )
                                        .accumulatingFiredPanes()
                                        .withAllowedLateness(Duration.ZERO)
                                        )
        .apply( BeamSql.query("SELECT count(*) from PCOLLECTION GROUP BY 
TUMBLE(CURRENT_TIMESTAMP, INTERVAL '1' MINUTE)"));
{code}

So I suppose {{Window.<T>configure().triggering}} should always use with 
{{Window.into}} together.

> support customized trigger/accumulationMode in BeamSql
> ------------------------------------------------------
>
>                 Key: BEAM-3749
>                 URL: https://issues.apache.org/jira/browse/BEAM-3749
>             Project: Beam
>          Issue Type: Improvement
>          Components: dsl-sql
>            Reporter: Xu Mingmin
>            Assignee: Xu Mingmin
>            Priority: Major
>             Fix For: 2.5.0
>
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> Currently BeamSql use {{DefaultTrigger}} for aggregation operations. 
> By adding two options {{withTrigger(Trigger)}} and 
> {{withAccumulationMode(AccumulationMode)}}, developers can specify their own 
> aggregation strategies with BeamSql.
> [~xumingming] [~kedin] [~kenn] for any comments.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to