[ https://issues.apache.org/jira/browse/BEAM-3749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390311#comment-16390311 ]
Kenneth Knowles edited comment on BEAM-3749 at 3/7/18 9:58 PM: --------------------------------------------------------------- I think this link will clarify: [https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/Window.java#L333] The trigger is left alone if you use {{Window.into}} when the SQL sets up the window function. It will not set it to the {{DefaultTrigger}}. The code that you showed will use tumbling windows with the configured trigger. was (Author: kenn): I think this link will clarify: https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/Window.java#L333 The trigger is left alone if you use {{Window.into}} when the SQL sets up the window function. It will not set it to the {{DefaultTrigger}}. > support customized trigger/accumulationMode in BeamSql > ------------------------------------------------------ > > Key: BEAM-3749 > URL: https://issues.apache.org/jira/browse/BEAM-3749 > Project: Beam > Issue Type: Improvement > Components: dsl-sql > Reporter: Xu Mingmin > Assignee: Xu Mingmin > Priority: Major > Fix For: 2.5.0 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > Currently BeamSql use {{DefaultTrigger}} for aggregation operations. > By adding two options {{withTrigger(Trigger)}} and > {{withAccumulationMode(AccumulationMode)}}, developers can specify their own > aggregation strategies with BeamSql. > [~xumingming] [~kedin] [~kenn] for any comments. -- This message was sent by Atlassian JIRA (v7.6.3#76005)