[
https://issues.apache.org/jira/browse/BEAM-3803?focusedWorklogId=78946&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-78946
]
ASF GitHub Bot logged work on BEAM-3803:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Mar/18 17:18
Start Date: 09/Mar/18 17:18
Worklog Time Spent: 10m
Work Description: apilloud commented on a change in pull request #4823:
[BEAM-3803] [Nexmark] Handle both committed and attempted metrics
URL: https://github.com/apache/beam/pull/4823#discussion_r173512320
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/metrics/MetricResult.java
##########
@@ -32,14 +33,13 @@
/**
* Return the value of this metric across all successfully completed parts
of the pipeline.
- *
- * <p>Not all runners will support committed metrics. If they are not
supported, the runner will
- * throw an {@link UnsupportedOperationException}.
*/
+ @Nullable
Review comment:
Looks like I wasn't looking hard enough. There are implementations that obey
this contract. I'll update dataflow instead of changing it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 78946)
Time Spent: 2h 40m (was: 2.5h)
> [Nexmark] Not all runners support attempted metrics
> ---------------------------------------------------
>
> Key: BEAM-3803
> URL: https://issues.apache.org/jira/browse/BEAM-3803
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Reporter: Andrew Pilloud
> Assignee: Andrew Pilloud
> Priority: Major
> Labels: nexmark
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> The dataflow runner only supports committed metrics for batch jobs and
> attempted metrics for streaming jobs. Nexmark should use the best available
> metric source.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
