[
https://issues.apache.org/jira/browse/BEAM-3457?focusedWorklogId=78970&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-78970
]
ASF GitHub Bot logged work on BEAM-3457:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Mar/18 18:25
Start Date: 09/Mar/18 18:25
Worklog Time Spent: 10m
Work Description: lukecwik closed pull request #4819: [BEAM-3457] Drop Go
Maven PreCommit
URL: https://github.com/apache/beam/pull/4819
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.test-infra/jenkins/job_beam_PreCommit_Go_GradleBuild.groovy
b/.test-infra/jenkins/job_beam_PreCommit_Go_GradleBuild.groovy
index 509a8f3857e..63d7d66b557 100644
--- a/.test-infra/jenkins/job_beam_PreCommit_Go_GradleBuild.groovy
+++ b/.test-infra/jenkins/job_beam_PreCommit_Go_GradleBuild.groovy
@@ -43,7 +43,7 @@ job('beam_PreCommit_Go_GradleBuild') {
def gradle_command_line = './gradlew ' + gradle_switches.join(' ') + '
:goPreCommit'
// Sets that this is a PreCommit job.
- common_job_properties.setPreCommit(delegate, gradle_command_line, 'Run Go
Gradle PreCommit')
+ common_job_properties.setPreCommit(delegate, gradle_command_line, 'Run Go
PreCommit')
steps {
gradle {
rootBuildScriptDir(common_job_properties.checkoutDir)
diff --git a/.test-infra/jenkins/job_beam_PreCommit_Go_MavenInstall.groovy
b/.test-infra/jenkins/job_beam_PreCommit_Go_MavenInstall.groovy
deleted file mode 100644
index c616edc62ed..00000000000
--- a/.test-infra/jenkins/job_beam_PreCommit_Go_MavenInstall.groovy
+++ /dev/null
@@ -1,56 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-import common_job_properties
-
-// This is the Go precommit which runs a maven install, and the current set
-// of precommit tests.
-mavenJob('beam_PreCommit_Go_MavenInstall') {
- description('Runs an install of the current GitHub Pull Request.')
-
- previousNames('beam_PreCommit_MavenVerify')
-
- // Execute concurrent builds if necessary.
- concurrentBuild()
-
- // Set common parameters.
- common_job_properties.setTopLevelMainJobProperties(
- delegate,
- 'master',
- 150)
-
- // Set Maven parameters.
- common_job_properties.setMavenConfig(delegate)
-
- // Sets that this is a PreCommit job.
- common_job_properties.setPreCommit(delegate, 'mvn clean install -pl sdks/go
-am -amd', 'Run Go PreCommit')
-
- // Maven goals for this job: The Go SDK, its dependencies, and things that
depend on it.
- goals('''\
- --batch-mode \
- --errors \
- --activate-profiles
release,jenkins-precommit,direct-runner,dataflow-runner,spark-runner,flink-runner,apex-runner
\
- --projects sdks/go \
- --also-make \
- --also-make-dependents \
- -D pullRequest=$ghprbPullId \
- help:effective-settings \
- clean \
- install
- ''')
-}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 78970)
Time Spent: 5h (was: 4h 50m)
> Migrate Go Jenkins PreCommit to Gradle
> --------------------------------------
>
> Key: BEAM-3457
> URL: https://issues.apache.org/jira/browse/BEAM-3457
> Project: Beam
> Issue Type: Sub-task
> Components: build-system, testing
> Reporter: Luke Cwik
> Assignee: Henning Rohde
> Priority: Major
> Fix For: Not applicable
>
> Time Spent: 5h
> Remaining Estimate: 0h
>
> The code is here:
> https://github.com/apache/beam/blob/master/.test-infra/jenkins/job_beam_PreCommit_Go_MavenInstall.groovy
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
