ASF GitHub Bot logged work on BEAM-3565:

                Author: ASF GitHub Bot
            Created on: 13/Mar/18 04:51
            Start Date: 13/Mar/18 04:51
    Worklog Time Spent: 10m 
      Work Description: tgroh commented on a change in pull request #4777: 
[BEAM-3565] Add FusedPipeline#toPipeline
URL: https://github.com/apache/beam/pull/4777#discussion_r174016261

 File path: 
 @@ -61,12 +66,23 @@
    * <p>The returned {@link QueryablePipeline} will contain only the primitive 
transforms present
    * within the provided components.
-  public static QueryablePipeline fromComponents(Components components) {
+  public static QueryablePipeline forPrimitivesIn(Components components) {
+    return forComponents(retainOnlyPrimitives(components));
+  }
+  /**
+   * Create a new {@link QueryablePipeline} based on the provided components.
+   *
+   * <p>Relationships between composite transforms and their subtransforms, 
and producer
+   * relationships between {@link PTransformNode transforms} and {@link 
+   * PCollections} are not yet modelled by {@link QueryablePipeline}, so the 
input {@link
+   * Components} should be treatable as though each node is a primitive.
+   */
+  static QueryablePipeline forComponents(Components components) {
 Review comment:
   https://github.com/apache/beam/pull/4844 performs a lot of this change, 
without embedding the components within the stage.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 79773)
    Time Spent: 12.5h  (was: 12h 20m)

> Add utilities for producing a collection of PTransforms that can execute in a 
> single SDK Harness
> ------------------------------------------------------------------------------------------------
>                 Key: BEAM-3565
>                 URL: https://issues.apache.org/jira/browse/BEAM-3565
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-core
>            Reporter: Thomas Groh
>            Assignee: Thomas Groh
>            Priority: Major
>              Labels: portability
>             Fix For: 2.4.0
>          Time Spent: 12.5h
>  Remaining Estimate: 0h
> An SDK Harness executes some ("fused") collection of PTransforms. The java 
> runner libraries should provide some way to take a Pipeline that executes in 
> both a runner and an environment and construct a collection of transforms 
> which can execute within a single environment.

This message was sent by Atlassian JIRA

Reply via email to