[
https://issues.apache.org/jira/browse/BEAM-3213?focusedWorklogId=79917&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-79917
]
ASF GitHub Bot logged work on BEAM-3213:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Mar/18 16:06
Start Date: 13/Mar/18 16:06
Worklog Time Spent: 10m
Work Description: lgajowy opened a new pull request #4859: [BEAM-3213]
MongodbIO performance test
URL: https://github.com/apache/beam/pull/4859
An IT for MongoDBIO.
I suggested different Kubernetes scripts naming for mongo than for postgres
scripts. The postgres' naming is quite confusing to me - the "local" scripts
are used everywhere right now, not only while running tests locally, so why
call them "local"?
There is another thing that bothers me: the node port service Kubernetes
setup can be used only if the *whole* test (including `setup()` and
`teardown()` methods) is run in the same network, as the k8 cluster is (to have
direct access to pod IPs). This doesn't happen on Jenkins nor while running
locally. This can happen if we are running sole pipeline without
settingUp()/tearingDown() any connections but it's a rare situation for tests
using databases. Also it works for Dataflow runner only.
Maybe we should consider dropping the node port service from Kubernetes
scripts and keep load balancer service only? Maybe there are some historical
reasons I am not aware of?
@chamikaramj @alanmyrvold could you take a look?
------------------------
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the
change (usually before you start working on it). Trivial changes like typos do
not require a JIRA issue. Your pull request should address just this issue,
without pulling in other changes.
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue.
- [ ] Write a pull request description that is detailed enough to
understand:
- [ ] What the pull request does
- [ ] Why it does it
- [ ] How it does it
- [ ] Why this approach
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 79917)
Time Spent: 10m
Remaining Estimate: 0h
> Add a performance test for MongoDBIO
> ------------------------------------
>
> Key: BEAM-3213
> URL: https://issues.apache.org/jira/browse/BEAM-3213
> Project: Beam
> Issue Type: Test
> Components: io-java-mongodb
> Reporter: Chamikara Jayalath
> Assignee: Łukasz Gajowy
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We should add a large scale performance test for MongoDBIO. We could use
> PerfKitBenchmarker based performance testing framework [1] to manage a
> Kubernetes based multi-node MongoDB cluster and to publish benchmark results.
> Example docker image to use: https://hub.docker.com/_/mongo/
> [1] https://beam.apache.org/documentation/io/testing/
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
