ASF GitHub Bot logged work on BEAM-2281:

                Author: ASF GitHub Bot
            Created on: 13/Mar/18 23:19
            Start Date: 13/Mar/18 23:19
    Worklog Time Spent: 10m 
      Work Description: apilloud opened a new pull request #4865: 
[BEAM-2281][Sql] Use SqlFunctions.toBigDecimal not toString
URL: https://github.com/apache/beam/pull/4865
   Instead of using BigDecimal(object.toString()) to convert, use 
SqlFunctions.toBigDecimal which converts directly between numeric types. This 
speeds up the Nexmark Query 2 parDo by 2x.
   Follow this checklist to help us incorporate your contribution quickly and 
    - [X] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the 
change (usually before you start working on it).  Trivial changes like typos do 
not require a JIRA issue.  Your pull request should address just this issue, 
without pulling in other changes.
    - [X] Format the pull request title like `[BEAM-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA 
    - [X] Write a pull request description that is detailed enough to 
      - [X] What the pull request does
      - [X] Why it does it
      - [X] How it does it
      - [X] Why this approach
    - [X] Each commit in the pull request should have a meaningful subject line 
and body.
    - [X] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

            Worklog Id:     (was: 80123)
            Time Spent: 10m
    Remaining Estimate: 0h

> call SqlFunctions in operator implementation
> --------------------------------------------
>                 Key: BEAM-2281
>                 URL: https://issues.apache.org/jira/browse/BEAM-2281
>             Project: Beam
>          Issue Type: Improvement
>          Components: dsl-sql
>            Reporter: Xu Mingmin
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
> Calcite has a collections of functions in 
> {{org.apache.calcite.runtime.SqlFunctions}}. It sounds a good source to 
> leverage when adding operators as {{BeamSqlExpression}}. 
> [~xumingming] [~app-tarush], any comments?

This message was sent by Atlassian JIRA

Reply via email to