[
https://issues.apache.org/jira/browse/BEAM-3841?focusedWorklogId=80890&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-80890
]
ASF GitHub Bot logged work on BEAM-3841:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Mar/18 17:12
Start Date: 15/Mar/18 17:12
Worklog Time Spent: 10m
Work Description: robertwb closed pull request #4856: [BEAM-3841] Fix
TestDataflowRunner.run to run_pipeline
URL: https://github.com/apache/beam/pull/4856
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/sdks/python/apache_beam/runners/dataflow/test_dataflow_runner.py
b/sdks/python/apache_beam/runners/dataflow/test_dataflow_runner.py
index b2330c04d57..aad3fc7b88f 100644
--- a/sdks/python/apache_beam/runners/dataflow/test_dataflow_runner.py
+++ b/sdks/python/apache_beam/runners/dataflow/test_dataflow_runner.py
@@ -27,7 +27,7 @@
class TestDataflowRunner(DataflowRunner):
- def run(self, pipeline):
+ def run_pipeline(self, pipeline):
"""Execute test pipeline and verify test matcher"""
options = pipeline._options.view_as(TestOptions)
on_success_matcher = options.on_success_matcher
@@ -36,7 +36,7 @@ def run(self, pipeline):
# send this option to remote executors.
options.on_success_matcher = None
- self.result = super(TestDataflowRunner, self).run(pipeline)
+ self.result = super(TestDataflowRunner, self).run_pipeline(pipeline)
if self.result.has_job:
project = pipeline._options.view_as(GoogleCloudOptions).project
region_id = pipeline._options.view_as(GoogleCloudOptions).region
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 80890)
Time Spent: 0.5h (was: 20m)
> Python TestDataflowRunner should oeverride run_pipeline
> -------------------------------------------------------
>
> Key: BEAM-3841
> URL: https://issues.apache.org/jira/browse/BEAM-3841
> Project: Beam
> Issue Type: Bug
> Components: testing
> Reporter: Mark Liu
> Assignee: Mark Liu
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> [TestDataflowRunner|https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/dataflow/test_dataflow_runner.py]
> is inherited from
> [DataflowRunner|https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/dataflow/dataflow_runner.py].
> Basically, it wraps DataflowRunner.run_pipeline and provide more test
> actions.
> However DataflowRunner.run renamed to run_pipeline in [this
> commit|https://github.com/apache/beam/commit/8cf222d3db1188aff5432af548961fc670f97635],
> but run function in TestDataflowRunner didn't change.
> We should change it accordingly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
