[
https://issues.apache.org/jira/browse/BEAM-3738?focusedWorklogId=81455&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-81455
]
ASF GitHub Bot logged work on BEAM-3738:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Mar/18 00:23
Start Date: 17/Mar/18 00:23
Worklog Time Spent: 10m
Work Description: aaltay closed pull request #4801: [BEAM-3738] Enable
py3 lint
URL: https://github.com/apache/beam/pull/4801
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/sdks/python/setup.py b/sdks/python/setup.py
index 5ed623b2293..5ef1683e81b 100644
--- a/sdks/python/setup.py
+++ b/sdks/python/setup.py
@@ -204,7 +204,6 @@ def generate_common_urns():
]),
setup_requires=REQUIRED_SETUP_PACKAGES,
install_requires=REQUIRED_PACKAGES,
- python_requires='>=2.7,<3.0',
test_suite='nose.collector',
tests_require=REQUIRED_TEST_PACKAGES,
extras_require={
diff --git a/sdks/python/tox.ini b/sdks/python/tox.ini
index 857e7b0e571..7d4152602f8 100644
--- a/sdks/python/tox.ini
+++ b/sdks/python/tox.ini
@@ -17,8 +17,7 @@
[tox]
# new environments will be excluded by default unless explicitly added to
envlist.
-# TODO (after BEAM-3671) add lint_py3 back in.
-envlist = py27,py27gcp,py27cython,lint_py2,docs
+envlist = py27,py27gcp,py27cython,lint_py2,lint_py3,docs
toxworkdir = {toxinidir}/target/.tox
[pycodestyle]
@@ -103,7 +102,6 @@ whitelist_externals=time
commands =
python --version
pip --version
- time pip install -e .[test]
time {toxinidir}/run_pylint.sh
passenv = TRAVIS*
@@ -116,12 +114,13 @@ deps=
isort==4.2.15
flake8==3.5.0
whitelist_externals=time
+basepython=python3
commands =
- time pip install -e .[test]
+ python --version
+ pip --version
time {toxinidir}/run_mini_py3lint.sh
passenv = TRAVIS*
-
[testenv:docs]
deps=
nose==1.3.7
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 81455)
Time Spent: 5h 40m (was: 5.5h)
> Enable Py3 linting in Jenkins
> -----------------------------
>
> Key: BEAM-3738
> URL: https://issues.apache.org/jira/browse/BEAM-3738
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core, testing
> Reporter: holdenk
> Assignee: Ahmet Altay
> Priority: Major
> Time Spent: 5h 40m
> Remaining Estimate: 0h
>
> After BEAM-3671 is finished enable linting.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
